Skip to content

Remove options to cutout from TICA products #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 17, 2025
Merged

Conversation

snbianco
Copy link
Contributor

@snbianco snbianco commented Aug 7, 2025

Due to lack of use and growing storage costs, MAST has decided to stop making and storing cubes from Tess Image Calibrated (TICA) products. This PR removes "TICA" as a valid option for the product parameter in relevant methods from the Tesscut class. It also deprecates the product parameter to be removed in a future release as it will only have one acceptable value moving forward.

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.18%. Comparing base (0d351b5) to head (43a1b1f).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3391      +/-   ##
==========================================
+ Coverage   70.15%   70.18%   +0.02%     
==========================================
  Files         232      232              
  Lines       19948    19937      -11     
==========================================
- Hits        13995    13992       -3     
+ Misses       5953     5945       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snbianco snbianco changed the title Remove tica Remove options to cutout from TICA products Aug 7, 2025
@snbianco snbianco marked this pull request as ready for review August 11, 2025 13:23
@snbianco snbianco added the mast label Aug 11, 2025
@snbianco snbianco requested a review from bsipocz August 14, 2025 13:29
@bsipocz bsipocz added this to the v0.4.11 milestone Aug 14, 2025
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks!

services = {"sector": {"path": "sector"},
"astrocut": {"path": "astrocut"},
"mt_sector": {"path": "moving_target/sector"},
"mt_astrocut": {"path": "moving_target/astrocut"}
}
self._service_api_connection.set_service_params(services, "tesscut")

def _validate_target_input(self, coordinates, objectname, moving_target):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for factoring out these duplications!

@bsipocz bsipocz merged commit 3a48e0f into astropy:main Aug 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants