-
-
Notifications
You must be signed in to change notification settings - Fork 420
Remove options to cutout from TICA products #3391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3391 +/- ##
==========================================
+ Coverage 70.15% 70.18% +0.02%
==========================================
Files 232 232
Lines 19948 19937 -11
==========================================
- Hits 13995 13992 -3
+ Misses 5953 5945 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks!
services = {"sector": {"path": "sector"}, | ||
"astrocut": {"path": "astrocut"}, | ||
"mt_sector": {"path": "moving_target/sector"}, | ||
"mt_astrocut": {"path": "moving_target/astrocut"} | ||
} | ||
self._service_api_connection.set_service_params(services, "tesscut") | ||
|
||
def _validate_target_input(self, coordinates, objectname, moving_target): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for factoring out these duplications!
Due to lack of use and growing storage costs, MAST has decided to stop making and storing cubes from Tess Image Calibrated (TICA) products. This PR removes "TICA" as a valid option for the
product
parameter in relevant methods from theTesscut
class. It also deprecates theproduct
parameter to be removed in a future release as it will only have one acceptable value moving forward.